On 8/12/20 19:46, Jacob Wen wrote: > wake_up_bit() uses waitqueue_active() that needs the explicit smp_mb(). > > Signed-off-by: Jacob Wen<jian.w.wen@xxxxxxxxxx> As per wake_up_bit() documentation this looks good. Reviewed-by: Chaitanya Kulkarni<chaitanya.kulkarni@xxxxxxx>