On Fri, Aug 07, 2020 at 03:55:19PM -0400, Vivek Goyal wrote: > This patch implements basic DAX support. mmap() is not implemented > yet and will come in later patches. This patch looks into implemeting > read/write. .... > +static int iomap_begin_setup_new_mapping(struct inode *inode, loff_t pos, > + loff_t length, unsigned flags, > + struct iomap *iomap) please doin't use the iomap_* namespace even for static functions in filesystem code. This really doesn't have anything to do with iomap except that whatever fuse sets up is used to fill an iomap. i.e. fuse_setup_new_dax_mapping() would be far more appropriate name. > +static int iomap_begin_upgrade_mapping(struct inode *inode, loff_t pos, > + loff_t length, unsigned flags, > + struct iomap *iomap) ditto: fuse_upgrade_dax_mapping(). Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
