On Wed, 2008-09-24 at 14:57 -0700, Badari Pulavarty wrote: > Hi Andrew, > > As part of moving all the filesystems to make use of new aops to > eventually remove prepare/commit_write, here is the patch to convert > ecryptfs to make use of new aops. > > Originally written by Nick, I did few minor fixes and clean ups. > Michael Halcrow tested and confirmed that it works. > > Thanks, > Badari > > > Convert ecryptfs to use new aops (write_begin/write_end) > > Signed-off-by: Nick Piggin <npiggin@xxxxxxx> > Signed-off-by: Badari Pulavarty <pbadari@xxxxxxxxxx> > Acked-by: Michael Halcrow <mhalcrow@xxxxxxxxxx> > @@ -497,7 +512,11 @@ static int ecryptfs_commit_write(struct > if (rc) > printk(KERN_ERR "Error writing inode size to metadata; " > "rc = [%d]\n", rc); > + > + rc = copied; I think we need an "else" before "rc = copied;". If rc is not zero, we should return the error from ecryptfs_write_inode_size_to_metadata(). > out: > + unlock_page(page); > + page_cache_release(page); > return rc; > } > Other than that, it looks okay to me. Shaggy -- David Kleikamp IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
