* Christoph Hellwig <hch@xxxxxx> wrote: > Hi all, > > the i386 ABI is a little special in that it uses less than natural > alignment for 64-bit integer types (u64 and s64), and a significant > amount of our compat handlers deals with just that. Unfortunately > there is no good way to check for this specific quirk at runtime, > similar how in_compat_syscall() checks for a compat syscall. This > series adds such a check, and then uses the quota code as an example > of how this improves the compat handling. I have a few other places > in mind where this will also be useful going forward. > > Changes since v1: > - use asm-generic/compat.h instead of linux/compat.h for > compat_u64 and compat_s64 > - fix a typo > > Diffstat: > b/arch/arm64/include/asm/compat.h | 2 > b/arch/mips/include/asm/compat.h | 2 > b/arch/parisc/include/asm/compat.h | 2 > b/arch/powerpc/include/asm/compat.h | 2 > b/arch/s390/include/asm/compat.h | 2 > b/arch/sparc/include/asm/compat.h | 3 > b/arch/x86/entry/syscalls/syscall_32.tbl | 2 > b/arch/x86/include/asm/compat.h | 3 > b/fs/quota/Kconfig | 5 - > b/fs/quota/Makefile | 1 > b/fs/quota/compat.h | 34 ++++++++ > b/fs/quota/quota.c | 73 +++++++++++++++--- > b/include/asm-generic/compat.h | 8 ++ > b/include/linux/compat.h | 9 ++ > b/include/linux/quotaops.h | 3 > b/kernel/sys_ni.c | 1 > fs/quota/compat.c | 120 ------------------------------- > 17 files changed, 113 insertions(+), 159 deletions(-) If nobody objects to this being done at runtime, and if it's 100% ABI compatible, then the x86 impact looks good to me: Acked-by: Ingo Molnar <mingo@xxxxxxxxxx> Thanks, Ingo
