On Tue, Jul 28, 2020 at 12:04 PM Jan Kara <jack@xxxxxxx> wrote: > > On Tue 28-07-20 11:06:25, Amir Goldstein wrote: > > On Tue, Jul 28, 2020 at 10:42 AM Jan Kara <jack@xxxxxxx> wrote: > > > > > > On Tue 28-07-20 09:51:08, Amir Goldstein wrote: > > > > This was missed when splitting name event from fid event > > > > > > > > Fixes: cacfb956d46e ("fanotify: record name info for FAN_DIR_MODIFY event") > > > > Cc: <stable@xxxxxxxxxxxxxxx> # v5.7+ > > > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > > > > > > OK, but given we never enabled FAN_DIR_MODIFY in 5.7, this is just a dead > > > code there, isn't it? So it should be enough to fix this for the series > > > that's currently queued? > > > > Doh! you are right. > > So you can just work it into the series and remove the explicit stable tag. > > If we leave the Fixes tag, stable bots will probably pick this up, but OTOH, > > there is no harm in applying the patch to stable kernel, so whatever. > > Attached is what I have pushed to my tree. > Excellent. Thanks, Amir.