On Wed 22-07-20 15:58:40, Amir Goldstein wrote: > Jan, > > Following your feedback [1] to fanotify name events, I wrote some LTP > tests [2] to add missing test coverage: > > 1) dnotify/inotify: report event to both parent and child - > catches the dnotify bug I had in v4 after unified event patch > > 2) fanotify10: add groups with FAN_REPORT_NAME to the setup - > catches the bug you noticed in fanotify_group_event_mask() > > 3) fanotify10: add test cases with ignored mask on watching parent - > catches the inconsistecy with ignored masks that you noticed [*] > > The patches in this series apply to your fsnotify branch and are > avaiable on my fsnotify-fixes branch [3]. > > Patch 1 fixes issue #2 above > Patch 2 fixes another issue found by tests > Patch 3 fixes a minor issue found by code review > Patches 4-6 simplify the code based on your suggestions > Patch 7 depends on 4-6 and fixes issue #3 above [*] > > Optional patches: > Patch 8 implements your suggestion of simplified handler_event() > Patch 9 is a possible fix for kernel test robot reported performance > regression. I did not get any feedback on it, but it is trivial. OK, so I've added patches 1-8 to my tree. I've checked that the final resulting source after my patch reorg is the same as after just applying the patches. LTP tests pass so I've pushed out everything to linux-next to give it some more beating. So everything should be ready for the merge window. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR