On Fri, Jul 17, 2020 at 11:09:13PM +0200, Thomas Gleixner wrote: > Christoph Hellwig <hch@xxxxxx> writes: > > > Switch over all instances used directly as methods using these sed > > expressions: > > > > sed -i -e 's/\.read\(\s*=\s*\)seq_read/\.read_iter\1seq_read_iter/g' > > This sucks, really. I just got a patch against this converting the > changed version to DEFINE_SHOW_ATTRIBUTE(somefile) and thereby removing > the whole open coded gunk. The changed version of what? > If we do a tree wide change like this, then can we pretty please use a > coccinelle script to convert all trivial instances to use > DEFINE_SHOW_ATTRIBUTE so we don't have to touch the same place over and > over. I'm not going to complain about that if someone offers a script for that.