On Tue, Sep 16, 2008 at 11:29:41AM +0200, Marco Stornelli wrote: > From: Marco Stornelli <marco.stornelli@xxxxxxxxx> > > If a filesystem in the file operations specifies for read and write operations only do_sync_read and do_sync_write without > init aio_read and aio_write, there will be a kernel oops, because the vfs code check the presence of (to read for example) > read OR aio_read method, then it calls read if it's pointer is not null. It's not sufficient because if the read function is > actually a do_sync_read, it calls aio_read but without checking the presence. I think a BUG_ON check can be more useful. A NULL pointer derference is just as clear as the bug.. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
