On Thu 16-07-20 11:42:24, Amir Goldstein wrote: > Remove the unneeded check for positive source dentry in > fsnotify_move(). > > fsnotify_move() hook is mostly called from vfs_rename() under > lock_rename() and vfs_rename() starts with may_delete() test that > verifies positive source dentry. The only other caller of > fsnotify_move() - debugfs_rename() also verifies positive source. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> But in vfs_rename() if RENAME_EXCHANGE is set and target is NULL, new_dentry can be negative when calling fsnotify_move() AFAICT, cannot it? Honza > --- > include/linux/fsnotify.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h > index 044cae3a0628..fe4f2bc5b4c2 100644 > --- a/include/linux/fsnotify.h > +++ b/include/linux/fsnotify.h > @@ -149,8 +149,7 @@ static inline void fsnotify_move(struct inode *old_dir, struct inode *new_dir, > if (target) > fsnotify_link_count(target); > > - if (source) > - fsnotify(source, mask, source, FSNOTIFY_EVENT_INODE, NULL, 0); > + fsnotify(source, mask, source, FSNOTIFY_EVENT_INODE, NULL, 0); > audit_inode_child(new_dir, moved, AUDIT_TYPE_CHILD_CREATE); > } > > -- > 2.17.1 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
