On Tue, Jul 14, 2020 at 08:31:03AM -0500, Eric W. Biederman wrote: > > In preparation for implementiong kernel_execve (which will take kernel > pointers not userspace pointers) factor out bprm_stack_limits out of > prepare_arg_pages. This separates the counting which depends upon the > getting data from userspace from the calculations of the stack limits > which is usable in kernel_execve. > > The remove prepare_args_pages and compute bprm->argc and bprm->envc > directly in do_execveat_common, before bprm_stack_limits is called. > > Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> > --- This looks basically identical to my "exec: split prepare_arg_pages". I slightly prefer the version I had, but this looks ok as well: Reviewed-by: Christoph Hellwig <hch@xxxxxx>