On Mon, Jul 13, 2020 at 12:59:47PM +0100, Matthew Wilcox wrote: > On Sun, Jul 12, 2020 at 08:09:52PM -0700, Eric Biggers wrote: > > Define the VFS inode flags using bit numbers instead of hardcoding > > powers of 2, which has become unwieldy now that we're up to 65536. > > If you're going to change these, why not use the BIT() macro? > Either way would be fine with me, but I've seen people complain about BIT() before and say they prefer just (1 << n). - Eric