On Thu, Jul 9, 2020 at 10:33 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Amir, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on ext3/fsnotify] > [also build test WARNING on nfsd/nfsd-next driver-core/driver-core-testing linus/master v5.8-rc4 next-20200708] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Amir-Goldstein/fsnotify-Rearrange-fast-path-to-minimise-overhead-when-there-is-no-watcher/20200708-191525 > base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify > config: x86_64-allyesconfig (attached as .config) > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 02946de3802d3bc65bc9f2eb9b8d4969b5a7add8) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > >> fs/notify/fanotify/fanotify.c:347:24: warning: no previous prototype for function 'fanotify_alloc_path_event' [-Wmissing-prototypes] > struct fanotify_event *fanotify_alloc_path_event(const struct path *path, > ^ > fs/notify/fanotify/fanotify.c:347:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > struct fanotify_event *fanotify_alloc_path_event(const struct path *path, > ^ > static > >> fs/notify/fanotify/fanotify.c:363:24: warning: no previous prototype for function 'fanotify_alloc_perm_event' [-Wmissing-prototypes] > struct fanotify_event *fanotify_alloc_perm_event(const struct path *path, > ^ > fs/notify/fanotify/fanotify.c:363:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > struct fanotify_event *fanotify_alloc_perm_event(const struct path *path, > ^ > static > >> fs/notify/fanotify/fanotify.c:381:24: warning: no previous prototype for function 'fanotify_alloc_fid_event' [-Wmissing-prototypes] > struct fanotify_event *fanotify_alloc_fid_event(struct inode *id, > ^ > fs/notify/fanotify/fanotify.c:381:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > struct fanotify_event *fanotify_alloc_fid_event(struct inode *id, > ^ > static > >> fs/notify/fanotify/fanotify.c:398:24: warning: no previous prototype for function 'fanotify_alloc_name_event' [-Wmissing-prototypes] > struct fanotify_event *fanotify_alloc_name_event(struct inode *id, > ^ > fs/notify/fanotify/fanotify.c:398:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > struct fanotify_event *fanotify_alloc_name_event(struct inode *id, > ^ > static > 4 warnings generated. Jan, I add 'static' rebased and pushed to fanotify_prep branch Rebase had minor conflict in following patch (pass dir argument ...) Also rebased and pushed fanotify_name_fid Thanks, Amir.
