On Sun, Sep 14, 2008 at 12:10:27AM +1000, Dave Chinner wrote:
> + * we need to provide an empty inode free function to prevent
> + * the generic code from trying to free ouuur combined inode.
^^^^ spelling?
> -
> -STATIC void
> -xfs_fs_inode_init_once(
> - void *vnode)
> + struct inode *inode)
> {
> - inode_init_once((struct inode *)vnode);
> + return;
> }
No need for a no-argument return at the end of the function.
> static inline int xfs_icount(struct xfs_inode *ip)
> {
> - struct inode *inode = VFS_I(ip);
> -
> - if (!inode)
> - return atomic_read(&inode->i_count);
> - return -1;
> + return atomic_read(&VFS_I(ip)->i_count);
> }
At this point we can just kill this helper - there's only one caller
anyway.
> - if (xfs_iflush(ip, sync_mode) == 0) {
> + if (!VN_BAD(VFS_I(ip)) && xfs_iflush(ip, sync_mode) == 0) {
Why don't you switch to is_bad_inode directly instead of fixing this
up in a later patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
