The sparse tool complains as follows: fs/fs_parser.c:192:5: warning: symbol 'fs_param_bad_value' was not declared. Should it be static? Function fs_param_bad_value() is not used outside of fs_parser.c, so marks it static. Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> --- fs/fs_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fs_parser.c b/fs/fs_parser.c index ab53e42a874a..68b0148f4bb8 100644 --- a/fs/fs_parser.c +++ b/fs/fs_parser.c @@ -189,7 +189,7 @@ int fs_lookup_param(struct fs_context *fc, } EXPORT_SYMBOL(fs_lookup_param); -int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) +static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) { return inval_plog(log, "Bad value for '%s'", param->key); }