On Fri 12-06-20 12:33:32, Amir Goldstein wrote: > The 'inode' argument to handle_event(), sometimes referred to as > 'to_tell' is somewhat obsolete. > It is a remnant from the times when a group could only have an inode mark > associated with an event. > > We now pass an iter_info array to the callback, with all marks associated > with an event. > > Most backends ignore this argument, with two expections: ^^ exceptions > 1. dnotify uses it for sanity check that event is on directory > 2. fanotify uses it to report fid of directory on directory entry > modification events > > Remove the 'inode' argument and add a 'dir' argument. > The callback function signature is deliberately changed, because > the meaning of the argument has changed and the arguments have > been documented. > > The 'dir' argument is NULL when "sending" to a non-dir inode. > When 'file_name' argument is non NULL, 'dir' is always referring to > the directory that the 'file_name' entry belongs to. > > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> Otherwise the patch looks good to me. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
