Re: [PATCH] f2fs: always expose label 'next_page'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/30/20 1:23 PM, Jaegeuk Kim wrote:
> On 06/30, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>> Fix build error when F2FS_FS_COMPRESSION is not set/enabled.
>> This label is needed in either case.
>>
>> ../fs/f2fs/data.c: In function ‘f2fs_mpage_readpages’:
>> ../fs/f2fs/data.c:2327:5: error: label ‘next_page’ used but not defined
>>      goto next_page;
> 
> Thank you for the fix. This was actually introduced by the recent testing patch.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=ff963ad2bf54460431f517b5cae473997a29bf2a
> 
> If you don't mind, please let me integrate this into the original patch.
> Let me know.

Sure, no problem.

> Thanks,
> 
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Cc: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
>> Cc: Chao Yu <yuchao0@xxxxxxxxxx>
>> Cc: linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
>> ---
>>  fs/f2fs/data.c |    2 --
>>  1 file changed, 2 deletions(-)
>>
>> --- linux-next-20200630.orig/fs/f2fs/data.c
>> +++ linux-next-20200630/fs/f2fs/data.c
>> @@ -2366,9 +2366,7 @@ set_error_page:
>>  			zero_user_segment(page, 0, PAGE_SIZE);
>>  			unlock_page(page);
>>  		}
>> -#ifdef CONFIG_F2FS_FS_COMPRESSION
>>  next_page:
>> -#endif
>>  		if (rac)
>>  			put_page(page);
>>  


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux