On Tue, 9 Sep 2008, Christoph Hellwig wrote: > On Tue, Sep 09, 2008 at 03:19:57PM +0200, Miklos Szeredi wrote: > > > + * and will be casted to the corresponding NULL or IS_ERR dentry. > > > + */ > > > > Mixing NULL with ERR_PTR() seems like a bad idea. It should be either > > one or the other but not both. > > It's how the existing interface works. If you mean ->fh_to_dentry() and ->fh_to_parent(), yes they do work this way. But a NULL return is simply equivalent to a -ESTALE return, so why not turn !inode inot an -ESTALE in d_obtain_alias()? That would fix the interface and the bug in fuse. Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
