Kees Cook <keescook@xxxxxxxxxxxx> writes: > On Fri, Jun 26, 2020 at 07:55:43AM -0500, Eric W. Biederman wrote: >> This structure is only used for user mode drivers so change >> the prefix from umh to umd to make that clear. > > Should bpfilter_umh get renamed to bpfilter_umd at some point in this > series too? I think it would make a natural follow on, in a patches welcome sort of way. In this series I think it is important to draw a clear line between the user mode driver infrastructure and the more general user mode helper infrastructure. As it fundamentally makes a difference when you are skimming through the code trying to find the details you care about. But that line, which removes the maintenance burden from everyone else is where this series stops. I will be reposting shortly to fix the build issue I overlooked. Eric
