Re: [PATCH 6/9] sysctl: Call sysctl_head_finish on error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 6/9] sysctl: Call sysctl_head_finish on error
From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Date: Fri, 26 Jun 2020 12:17:01 +0000
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Iurii Zaikin <yzaikin@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20200626075836.1998185-7-hch@lst.de>

On Fri, Jun 26, 2020 at 09:58:33AM +0200, Christoph Hellwig wrote:
> From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
> 
> This error path returned directly instead of calling sysctl_head_finish().

And if the commit log can say why this was bad. Found through code
inspection from what I recall right?

  Luis

Follow-Ups:
- Re: [PATCH 6/9] sysctl: Call sysctl_head_finish on error
  - From: Matthew Wilcox

References:
- [RFC] stop using ->read and ->write for kernel access v2
  - From: Christoph Hellwig
- [PATCH 6/9] sysctl: Call sysctl_head_finish on error
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 2/9] proc: add a read_iter method to proc proc_ops
Next by Date: Re: [PATCH 8/9] fs: don't allow kernel reads and writes without iter ops
Previous by thread: [PATCH 6/9] sysctl: Call sysctl_head_finish on error
Next by thread: Re: [PATCH 6/9] sysctl: Call sysctl_head_finish on error
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux