On Tue, Jun 23, 2020 at 01:53:48PM -0500, Eric W. Biederman wrote: > Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx> writes: > > > On Tue, Jun 23, 2020 at 01:04:02PM -0500, Eric W. Biederman wrote: > >> > >> Sigh. I was busy last week so I left reading this until now in the > >> hopes I would see something reasonable. > >> > >> What I see is rejecting of everything that is said to you. > >> > >> What I do not see are patches fixing issues. I will await patches. > > > > huh? > > I can say exactly the same. You keep ignoring numerous points I brought up. > > You still haven't showed what kind of refactoring you have in mind and > > why fork_blob is in its way. > > That is correct. What I wind up doing with exec is irrelevant. > > What is relevant is getting correct working code on the fork_blob path. > Something that is clean enough that whatever weird things it winds up > doing are readable. The way things are intermingled today it took 2 > years for someone to realize there was a basic reference counting bug. There is no refcnt bug. It was a user error on tomoyo side. fork_blob() works as expected. > This isn't work anyone else can do because there are not yet any real in > tree users of fork_blob. The fact that no one else can make > substantials changes to the code because it has no users is what gets in > the way of maintenance. Not true either. bpfilter is a full blown user. bpfilter itself didn't go anywhere, but that's a different story. > One of the 2 year old bugs that needs to be fixed is that some LSMs > work in terms of paths. Tetsuo has been very gracious in pointing that > out. Either a path needs to be provided or the LSMs that work in terms > of paths need to be fixed. Not true again. usermode_blob is part of the kernel module. Kernel module when loaded doesn't have path. tomoyo has to fix itself. > Now I really don't care how the bugs are fixed. > > > My recomendation for long term maintenance is to split fork_blob into 2 > functions: fs_from_blob, and the ordinary call_usermodehelper_exec. what is fs_from_blob() ? If you mean to create a file system from a blob then it makes no sense. Please read upthread why. I'm not going to repeat the same points. > So patches to fix the bugs please. There are bugs. Ok? This pointless thread is happening because you want to do some refactoring of the code and somehow believe that fork_blob is in your way. If you cannot do refactoring without screaming about removal and misreading implementation details may be you shouldn't be doing that refactoring.
