Hi, while the commit is the right one my guess for the cause was only correct by 50%. Old code was an own parser for the fs params, which silently ignores unknown params. New code uses: 476 opt = fs_parse(fc, &fuse_fs_parameters, param, &result); which fails on unknown params. I've no idea how to fix the kernel for libfuse 2.9.x again to allow unknown parameters - it seems there is no option for fs_parse todo so. Stefan Am 21.06.20 um 21:33 schrieb Stefan Priebe - Profihost AG: > Hi David, > > i did a git bisect and the breaking commit is: > > commit c30da2e981a703c6b1d49911511f7ade8dac20be > Author: David Howells <dhowells@xxxxxxxxxx> > Date: Mon Mar 25 16:38:31 2019 +0000 > > fuse: convert to use the new mount API > > Convert the fuse filesystem to the new internal mount API as the old > one will be obsoleted and removed. This allows greater flexibility in > communication of mount parameters between userspace, the VFS and the > filesystem. > > See Documentation/filesystems/mount_api.txt for more information. > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx> > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx> > > most probably due to the following diffences: > > > old default: > default: > - return 0; > > > new default: > + default: > + return -EINVAL; > > > it seems the old API silently did ignore unknown parameters while the > new one fails with EINVAL. > > I'm not sure who to blame here but this seems to break existing usespace > fuse programs or may be libfuse 2.9.X in general. > > Greets, > Stefan > > Am 19.06.20 um 21:02 schrieb Stefan Priebe - Profihost AG: >> >> Am 19.06.20 um 09:47 schrieb David Howells: >>> Stefan Priebe - Profihost AG <s.priebe@xxxxxxxxxxxx> wrote: >>> >>>> while using fuse 2.x and nonempty mount option - fuse mounts breaks >>>> after upgrading from kernel 4.19 to 5.4. >>> >>> Can you give us an example mount commandline to try? >> >> see fstab which daniel sent or: >> ceph-fuse /var/log/pve/tasks nonempty >> >> Greets, >> Stefan >> >>> >>> Thanks, >>> David >>>
