On Thu, Jun 18, 2020 at 02:24:08PM +0200, Andreas Gruenbacher wrote: > Make sure iomap_end is always called when iomap_begin succeeds. > > Without this fix, iomap_end won't be called when a filesystem's > iomap_begin operation returns an invalid mapping, bypassing any > unlocking done in iomap_end. With this fix, the unlocking would > at least still happen. > > This iomap_apply bug was found by Bob Peterson during code review. > It's unlikely that such iomap_begin bugs will survive to affect > users, so backporting this fix seems unnecessary. > > Fixes: ae259a9c8593 ("fs: introduce iomap infrastructure") > Signed-off-by: Andreas Gruenbacher <agruenba@xxxxxxxxxx> Thanks for the updated commit message, Andreas. :) Patch looks good to me. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx