Re: [PATCH v4 09/11] selftests/seccomp: Rename user_trap_syscall() to user_notif_syscall()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Kees Cook <keescook@xxxxxxxxxxxx>
Subject: Re: [PATCH v4 09/11] selftests/seccomp: Rename user_trap_syscall() to user_notif_syscall()
From: Tycho Andersen <tycho@xxxxxxxx>
Date: Tue, 16 Jun 2020 08:56:14 -0600
Cc: linux-kernel@xxxxxxxxxxxxxxx, Sargun Dhillon <sargun@xxxxxxxxx>, Christian Brauner <christian@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Aleksa Sarai <cyphar@xxxxxxxxxx>, Matt Denton <mpdenton@xxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Chris Palmer <palmer@xxxxxxxxxx>, Robert Sesek <rsesek@xxxxxxxxxx>, Giuseppe Scrivano <gscrivan@xxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Will Drewry <wad@xxxxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, containers@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-api@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <20200616032524.460144-10-keescook@chromium.org>

On Mon, Jun 15, 2020 at 08:25:22PM -0700, Kees Cook wrote:
> The user_trap_syscall() helper creates a filter with
> SECCOMP_RET_USER_NOTIF. To avoid confusion with SECCOMP_RET_TRAP, rename
> the helper to user_notif_syscall().
> 
> Additionally fix a redundant "return" after XFAIL.
> 
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Reviewed-by: Tycho Andersen <tycho@xxxxxxxx>

References:
- [PATCH v4 00/11] Add seccomp notifier ioctl that enables adding fds
  - From: Kees Cook
- [PATCH v4 09/11] selftests/seccomp: Rename user_trap_syscall() to user_notif_syscall()
  - From: Kees Cook

Prev by Date: Re: [PATCH v4 10/11] seccomp: Switch addfd to Extensible Argument ioctl
Next by Date: Re: [PATCH v4 08/11] selftests/seccomp: Make kcmp() less required
Previous by thread: [PATCH v4 09/11] selftests/seccomp: Rename user_trap_syscall() to user_notif_syscall()
Next by thread: [PATCH v4 08/11] selftests/seccomp: Make kcmp() less required
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]