Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
From: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Date: Sat, 6 Jun 2020 13:43:26 -0700
Cc: Kees Cook <keescook@xxxxxxxxxxxx>, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, ast@xxxxxxxxxx, davem@xxxxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, bpf <bpf@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Gary Lin <GLin@xxxxxxxx>, Bruno Meneguele <bmeneg@xxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <875zc4c86z.fsf_-_@x220.int.ebiederm.org>

On Sat, Jun 06, 2020 at 02:20:36PM -0500, Eric W. Biederman wrote:
> @@ -39,7 +37,6 @@ static kernel_cap_t usermodehelper_inheritable = CAP_FULL_SET;
>  static DEFINE_SPINLOCK(umh_sysctl_lock);
>  static DECLARE_RWSEM(umhelper_sem);
>  static LIST_HEAD(umh_list);
> -static DEFINE_MUTEX(umh_list_lock);

You can delete the umh_list too; you've deleted all its users.

Follow-Ups:
- Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
  - From: Eric W. Biederman

References:
- [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
  - From: Eric W. Biederman

Prev by Date: Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
Next by Date: Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
Previous by thread: Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
Next by thread: Re: [RFC][PATCH] net/bpfilter: Remove this broken and apparently unmantained
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]