Jens Axboe <jens.axboe@xxxxxxxxxx> writes: > On Fri, Aug 22 2008, Pierre Ossman wrote: >> On Fri, 22 Aug 2008 11:24:48 +0200 >> Jens Axboe <jens.axboe@xxxxxxxxxx> wrote: >> >> > >> > I agree with that, the thought did cross my mind earlier as well. I >> > committed something like the below (in two patches). Do you want me to >> > queue up your mmc patches as well? >> > >> >> As it stands, no. If nobody can find a measurable improvement then this >> code is just more things that can go wrong. > > It could just be that the device you tested with doesn't do anything > with the discard information. But I agree, until there's a verified > benefit to adding the code, we can leave it be. That doesn't have improvement? E.g. it means the results dd if=/dev/zero of=/dev/xxx and ./discard_all /dev/xxx dd if=/dev/zero of=/dev/xxx are same? Or FAT doesn't have? -- OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
