On Fri, Aug 22 2008, Pierre Ossman wrote: > On Fri, 22 Aug 2008 11:58:16 +0100 > David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: > > > On Fri, 2008-08-22 at 12:50 +0200, Jens Axboe wrote: > > > > I suspect we need a separate 'max_discard_sectors' field. > > > > > > No, that is what max_hw_sectors is for. > > > > I thought Pierre's problem is that he has _different_ limits for > > discards vs. read/writes? > > > > Indeed. max_hw_sectors is _not_ used for "maximum number of sectors" in > most cases, but for "maximum number of bytes the device can transfer". > The difference between the two is irrelevant for data requests, but is > evident here. OK, I didn't notice the distinction for this case. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html