Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> sysnames should be freed after refcnt being decreased to zero in
> afs_put_sysnames().

* I suggest to use the wording “reference counter”.

* Where did you notice a “memory leak” here?


> Besides, it would be better set net->sysnames
> to 'NULL' after net->sysnames being released if afs_put_sysnames()
> aims on an afs_sysnames object.

* Would you like to consider an adjustment for this information?

* How do you think about to add an imperative wording?

* Will the tag “Fixes” become relevant for the commit message?

Regards,
Markus




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux