On Thu, May 28, 2020 at 04:14:44PM +1000, NeilBrown wrote: > I don't think we should just fix all those bugs in those filesystems. > I think that F_UNLCK should *always* remove the lock/lease. > I imaging this happening by *always* calling posix_lock_file() (or > similar) in the unlock case - after calling f_op->lock() first if that > is appropriate. > > What do people think? It there on obvious reason that is a non-starter? Isn't NFS unlock like close, in that it may be our only chance to return IO errors? But I guess you're not saying that unlock can't return errors, just that it should always remove the lock whether it returns 0 or not. Hm. --b.
