Re: [PATCH 09/11] exec: In bprm_fill_uid only set per_clear when honoring suid or sgid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [PATCH 09/11] exec: In bprm_fill_uid only set per_clear when honoring suid or sgid
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 28 May 2020 12:08:02 -0700
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxxxxx>, Rob Landley <rob@xxxxxxxxxxx>, Bernd Edlinger <bernd.edlinger@xxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Casey Schaufler <casey@xxxxxxxxxxxxxxxx>, LSM List <linux-security-module@xxxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, "Serge E. Hallyn" <serge@xxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>
In-reply-to: <87y2pcvz3b.fsf_-_@x220.int.ebiederm.org>

On Thu, May 28, 2020 at 8:53 AM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> It makes no sense to set active_per_clear when the kernel decides not
> to honor the executables setuid or or setgid bits.  Instead set
> active_per_clear when the kernel actually decides to honor the suid or
> sgid permission bits of an executable.

You seem to be confused about the naming yourself.

You talk about "active_per_clear", but the code is about "per_clear". WTF?

              Linus

Follow-Ups:
- Re: [PATCH 09/11] exec: In bprm_fill_uid only set per_clear when honoring suid or sgid
  - From: Eric W. Biederman

References:
- exec: Promised cleanups after introducing exec_update_mutex
  - From: Eric W. Biederman
- [PATCH 0/6] exec: Trivial cleanups for exec
  - From: Eric W. Biederman
- [PATCH 0/5] exec: Control flow simplifications
  - From: Eric W. Biederman
- [PATCH v2 0/8] exec: Control flow simplifications
  - From: Eric W. Biederman
- [PATCH 0/11] exec: cred calculation simplifications
  - From: Eric W. Biederman
- [PATCH 09/11] exec: In bprm_fill_uid only set per_clear when honoring suid or sgid
  - From: Eric W. Biederman

Prev by Date: Re: [PATCH 01/11] exec: Reduce bprm->per_clear to a single bit
Next by Date: Re: [PATCH 1/2] sched/uclamp: Add a new sysctl to control RT default boost value
Previous by thread: [PATCH 09/11] exec: In bprm_fill_uid only set per_clear when honoring suid or sgid
Next by thread: Re: [PATCH 09/11] exec: In bprm_fill_uid only set per_clear when honoring suid or sgid
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]