On Wed, May 27, 2020 at 04:17:53PM +0200, KP Singh wrote: > From: KP Singh <kpsingh@xxxxxxxxxx> > > It is currently mentioned in the comments to the function that iput > might sleep when the inode is destroyed. Have it call might_sleep, as > dput already does. > > Adding an explicity might_sleep() would help in quickly realizing that > iput is called from a place where sleeping is not allowed when > CONFIG_DEBUG_ATOMIC_SLEEP is enabled as noticed in the dicussion: You do realize that there are some cases where iput() *is* guaranteed to be non-blocking, right?