On Fri, May 22, 2020 at 04:47:19PM +0100, Al Viro wrote: > On Fri, May 22, 2020 at 01:37:23PM +0000, Krzysztof Wilczynski wrote: > > From: Krzysztof Wilczyński <kw@xxxxxxxxx> > > > > Also, remove extra tab after the FASYNC flag, and keep line under 80 > > characters. This also resolves the following Coccinelle warning: > > > > include/linux/fcntl.h:11:13-21: duplicated argument to & or | > > Now ask yourself what might be the reason for that "duplicated argument". > Try to figure out what the values of those constants might depend upon. > For extra points, try to guess what has caused the divergences. > > Please, post the result of your investigation in followup to this. I think the patch is actually right, despite the shockingly bad changelog. He's removed the duplicate 'O_NDELAY' and reformatted the lines.