Re: [PATCH v2 5/8] exec: Move the call of prepare_binprm into search_binary_handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
Subject: Re: [PATCH v2 5/8] exec: Move the call of prepare_binprm into search_binary_handler
From: James Morris <jmorris@xxxxxxxxx>
Date: Wed, 20 May 2020 07:30:53 +1000 (AEST)
Cc: linux-kernel@xxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Oleg Nesterov <oleg@xxxxxxxxxx>, Jann Horn <jannh@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Greg Ungerer <gerg@xxxxxxxxxxxxxx>, Rob Landley <rob@xxxxxxxxxxx>, Bernd Edlinger <bernd.edlinger@xxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Casey Schaufler <casey@xxxxxxxxxxxxxxxx>, linux-security-module@xxxxxxxxxxxxxxx, "Serge E. Hallyn" <serge@xxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>
In-reply-to: <87d070zrvx.fsf_-_@x220.int.ebiederm.org>
User-agent: Alpine 2.21 (LRH 202 2017-01-01)

On Mon, 18 May 2020, Eric W. Biederman wrote:

> 
> The code in prepare_binary_handler needs to be run every time
> search_binary_handler is called so move the call into search_binary_handler
> itself to make the code simpler and easier to understand.
> 
> Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Nice cleanup.

Reviewed-by: James Morris <jamorris@xxxxxxxxxxxxxxxxxxx>

-- 
James Morris
<jmorris@xxxxxxxxx>

References:
- exec: Promised cleanups after introducing exec_update_mutex
  - From: Eric W. Biederman
- [PATCH 0/6] exec: Trivial cleanups for exec
  - From: Eric W. Biederman
- [PATCH 0/5] exec: Control flow simplifications
  - From: Eric W. Biederman
- [PATCH v2 0/8] exec: Control flow simplifications
  - From: Eric W. Biederman
- [PATCH v2 5/8] exec: Move the call of prepare_binprm into search_binary_handler
  - From: Eric W. Biederman

Prev by Date: Re: [PATCH v2 2/8] exec: Factor security_bprm_creds_for_exec out of security_bprm_set_creds
Next by Date: Re: fcntl(F_DUPFD) causing apparent file descriptor table corruption
Previous by thread: Re: [PATCH v2 5/8] exec: Move the call of prepare_binprm into search_binary_handler
Next by thread: [PATCH v2 6/8] exec/binfmt_script: Don't modify bprm->buf and then return -ENOEXEC
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]