On Mon, May 18, 2020 at 06:30:55PM +0000, Luis Chamberlain wrote: > On Mon, May 18, 2020 at 11:17:47AM -0700, Kees Cook wrote: > > On Mon, May 18, 2020 at 05:25:09PM +0000, Luis Chamberlain wrote: > > > On Mon, May 18, 2020 at 09:08:22AM -0700, Kees Cook wrote: > > > > On Mon, May 18, 2020 at 05:57:27PM +0200, Stephen Kitt wrote: > > > > > ngroups_max is a read-only sysctl entry, reflecting NGROUPS_MAX. Make > > > > > it const, in the same way as cap_last_cap. > > > > > > > > > > Signed-off-by: Stephen Kitt <steve@xxxxxxx> > > > > > > > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> > > > > > > Kees, since there is quite a bit of sysctl cleanup stuff going on and I > > > have a fs sysctl kitchen cleanup, are you alright if I carry this in a > > > tree and send this to Andrew once done? This would hopefully avoid > > > merge conflicts between these patches. > > > > > > I have to still re-spin my fs sysctl stuff, but will wait to do that > > > once Xiaoming bases his series on linux-next. > > > > Yeah, totally. I don't technically have a sysctl tree (I've always just > > had akpm take stuff), so go for it. I'm just doing reviews. :) > > Oh, I don't want a tree either, it was just that I can imagine these > series can easily create conflcits, so I wanted to avoid that before > passing them on to Andrew. Yup, that's cool. I happily defer to you on these cleanups! :) -- Kees Cook
