Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > + if (req->page_done) > > + for (req->index = 0; req->index < req->nr_pages; req->index++) > > + req->page_done(req); > > + > > I'd suggest doing one call rather than N and putting the page iteration > inside the callback. But this patch is appropriate for this late in > the -rc series, just something to consider for the future. My rewrite of the fscache stuff changes this bit of the code anyway, and makes it one call which may start a write out to the cache. David
