Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to hung_task.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020/5/17 10:43, Kees Cook wrote:
On Sat, May 16, 2020 at 04:55:14PM +0800, Xiaoming Ni wrote:
+/*
+ * This is needed for proc_doulongvec_minmax of sysctl_hung_task_timeout_secs
+ * and hung_task_check_interval_secs
+ */
+static unsigned long hung_task_timeout_max = (LONG_MAX / HZ);

Please make this const. With that done, yes, looks great!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>


Thank you for your guidance, I will fix it in v3

In addition, I am a bit confused about the patch submission, and hope to get everyone's answer.   I made this patch based on the master branch. But as in conflict at https://lkml.org/lkml/2020/5/10/413, my patch will inevitably conflict. Should I modify to make patch based on "linux-next" branch to avoid conflict, or other branches?

Thanks
Xiaoming Ni




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux