On Fri, May 15, 2020 at 12:33:41PM +0800, Xiaoming Ni wrote: > Move hung_task sysctl interface to hung_task_sysctl.c. > Use register_sysctl() to register the sysctl interface to avoid > merge conflicts when different features modify sysctl.c at the same time. > > Signed-off-by: Xiaoming Ni <nixiaoming@xxxxxxxxxx> > --- > include/linux/sched/sysctl.h | 8 +---- > kernel/Makefile | 4 ++- > kernel/hung_task.c | 6 ++-- > kernel/hung_task.h | 21 ++++++++++++ > kernel/hung_task_sysctl.c | 80 ++++++++++++++++++++++++++++++++++++++++++++ Why a separate file? That ends up needing changes to Makefile, the creation of a new header file, etc. Why not just put it all into hung_task.c directly? -Kees -- Kees Cook
