While debugging an unrelated problem, I noticed these two cases fdput() is called after failed fdget() while reviewing at all the fdget() and fdput() paths in the kernel. Changes since v2: Patches 1&2 changed to get rid of goto. Changes since v1: Patch 1: Changed to address review comments to refine the code for improved readability in addition to the change to avoid fdput() on failed fdget() Patch 2: No change to v1. Including it in the series to keep the patches together. Shuah Khan (2): fs: avoid fdput() after failed fdget() in ksys_sync_file_range() fs: avoid fdput() after failed fdget() in kernel_read_file_from_fd() fs/exec.c | 6 +++--- fs/sync.c | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) -- 2.25.1
