On Tue, May 05, 2020 at 11:59:10AM +0200, Miklos Szeredi wrote: > IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so > generic_fillattr() will clear STATX_ATIME from the result_mask if the super > block is marked read only. > > This was probably not the intention, so fix to only clear STATX_ATIME if > the fs doesn't support atime at all. > > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx> > Acked-by: David Howells <dhowells@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>