mark type is resolved from flags but is not itself bitwise. That means user could send a combination and never note only one value was taken in consideration. This patch clarifies that fact in bit definitions. Thanks to Amir for explanations. Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx> --- include/uapi/linux/fanotify.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/fanotify.h b/include/uapi/linux/fanotify.h index a88c7c6d0692..675bf6bbbe50 100644 --- a/include/uapi/linux/fanotify.h +++ b/include/uapi/linux/fanotify.h @@ -71,7 +71,12 @@ #define FAN_MARK_FLUSH 0x00000080 /* FAN_MARK_FILESYSTEM is 0x00000100 */ -/* These are NOT bitwise flags. Both bits can be used togther. */ +/* + * These are NOT bitwise flags. Both bits can be used together. + * IOW if someone does FAN_MARK_INODE | FAN_MARK_FILESYSTEM + * it will be considered FAN_MARK_FILESYSTEM and user won't be + * notified. + */ #define FAN_MARK_INODE 0x00000000 #define FAN_MARK_MOUNT 0x00000010 #define FAN_MARK_FILESYSTEM 0x00000100 -- 2.26.2
