On Fri, May 08, 2020 at 01:48:13PM -0500, Eric W. Biederman wrote: > > Make the code more robust by marking the point of no return sooner. > This ensures that future code changes don't need to worry about how > they return errors if they are past this point. > > This results in no actual change in behavior as __do_execve_file does > not force SIGSEGV when there is a pending fatal signal pending past > the point of no return. Further the only error returns from de_thread > and exec_mmap that can occur result in fatal signals being pending. > > Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> Yes, thank you. I'm a fan; this makes the comment above the function a bit easier to understand, since the very first thing is to set the point_of_no_return. :) Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook
