Christoph Hellwig <hch@xxxxxx> writes: > On Tue, May 05, 2020 at 03:28:50PM -0500, Eric W. Biederman wrote: >> We probably can. After introducing a kernel_compat_siginfo that is >> the size that userspace actually would need. >> >> It isn't something I want to mess with until this code gets merged, as I >> think the set_fs cleanups are more important. >> >> >> Christoph made some good points about how ugly the #ifdefs are in >> the generic copy_siginfo_to_user32 implementation. > > Take a look at the series you are replying to, the magic x86 ifdefs are > entirely gone from the common code :) Interesting. That is a different way of achieving that, and I don't hate it. I still want whatever you are doing to settle before I touch that code again. Removing the set_fs is important and I have other fish to fry at the moment. Eric
