On Tue 05-05-20 17:43:17, Christoph Hellwig wrote: > iomap_fiemap already calls fiemap_check_flags first thing, so this > additional check is redundant. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx> Looks good to me. You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/ext4/extents.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index d2a2a3ba5c44a..a41ae7c510170 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -4866,9 +4866,6 @@ int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, > fieinfo->fi_flags &= ~FIEMAP_FLAG_CACHE; > } > > - if (fiemap_check_flags(fieinfo, FIEMAP_FLAG_SYNC | FIEMAP_FLAG_XATTR)) > - return -EBADR; > - > /* > * For bitmap files the maximum size limit could be smaller than > * s_maxbytes, so check len here manually instead of just relying on the > -- > 2.26.2 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
