Jan, In the v3 posting of the name info patches [1] I dropped the FAN_REPORT_NAME patches as agreed to defer them to next cycle. Following is remainder of the series to complement the FAN_DIR_MODIFY patches that were merged to v5.7-rc1. The v3 patches are available on my github branch fanotify_name [2]. Same branch names for LTP tests [3], man page draft [4] and a demo [5]. Patches 1-4 are cleanup and minor re-factoring in prep for the name info patches. Patch 5 adds the FAN_REPORT_NAME flag and the new event reporting format combined of FAN_EVENT_INFO_TYPE_DFID_NAME and FAN_EVENT_INFO_TYPE_FID info records, but provides not much added value beyond inotify. Patches 6-7 add the new capability of filesystem/mount watch with events including name info. I have made an API decision that stems from consolidating the implementation with fsnotify_parent() that requires your approval - A filesystem/mount mark with FAN_REPORT_NAME behaves as if all the directories and inodes are marked. This results in user getting all relevant events in two flavors - one with both info records and one with just FAN_EVENT_INFO_TYPE_FID. I have tries several approaches to work around this bizarrity, but in the end I decided that would be the lesser evil and that bizarre behavior is at least easy to document. Let me know what you think. Thanks, Amir. Main changes since v2: - FAN_DIR_MODIFY patches have been merged - A few more clean patches - More text about the motivation (in "report parent fid + name" patch) - Reduce code duplication with fsnotify_parent() [1] https://lore.kernel.org/linux-fsdevel/20200319151022.31456-1-amir73il@xxxxxxxxx/ [2] https://github.com/amir73il/linux/commits/fanotify_name [3] https://github.com/amir73il/ltp/commits/fanotify_name [4] https://github.com/amir73il/man-pages/commits/fanotify_name [5] https://github.com/amir73il/inotify-tools/commits/fanotify_name Amir Goldstein (7): fanotify: create overflow event type fanotify: break up fanotify_alloc_event() fanotify: generalize the handling of extra event flags fanotify: distinguish between fid encode error and null fid fanotify: report parent fid + name for events on children fsnotify: send event "on child" to sb/mount marks fanotify: report events "on child" with name info to sb/mount marks fs/notify/fanotify/fanotify.c | 213 +++++++++++++++++------------ fs/notify/fanotify/fanotify.h | 18 ++- fs/notify/fanotify/fanotify_user.c | 46 +++++-- fs/notify/fsnotify.c | 38 ++++- include/linux/fanotify.h | 2 +- include/linux/fsnotify_backend.h | 23 +++- include/uapi/linux/fanotify.h | 4 + 7 files changed, 231 insertions(+), 113 deletions(-) -- 2.17.1
