On Tue, May 5, 2020 at 12:50 PM Christoph Hellwig <hch@xxxxxx> wrote: > On Wed, Apr 29, 2020 at 11:49:52PM +0200, Jann Horn wrote: > > Both fs/binfmt_elf.c and fs/binfmt_elf_fdpic.c need to dump ranges of pages > > into the coredump file. Extract that logic into a common helper. > > > > Any other binfmt that actually wants to create coredumps will probably need > > the same function; so stop making get_dump_page() depend on > > CONFIG_ELF_CORE. > > Why is the #ifdef CONFIG_ELF_CORE in gup.c removed when the only > remaining caller is under the same ifdef? Oh, whoops, good point - I should go put that back.