On 04/05/2020 23:59, Richard Weinberger wrote: > Eric already raised doubts, let me ask more directly. > Does the checksum tree really cover all moving parts of BTRFS? > > I'm a little surprised how small your patch is. > Getting all this done for UBIFS was not easy and given that UBIFS is truly > copy-on-write it was still less work than it would be for other filesystems. > > If I understand the checksum tree correctly, the main purpose is protecting > you from flipping bits. > An attacker will perform much more sophisticated attacks. [ Adding Jeff with whom I did the design work ] The checksum tree only covers the file-system payload. But combined with the checksum field, which is the start of every on-disk structure, we have all parts of the filesystem checksummed.