On Wed, Apr 29, 2020 at 8:33 AM Jeremy Kerr <jk@xxxxxxxxxx> wrote: > > Hi Christoph, > > > And another one that should go on top of this one to address Al's other > > compaint: > > Yeah, I was pondering that one. The access_ok() is kinda redundant, but > it does avoid forcing a SPU context save on those errors. > > However, it's not like we really need to optimise for the case of > invalid addresses from userspace. So, I'll include this change in the > submission to Michael's tree. Arnd - let me know if you have any > objections. Sounds good. A lot of the access_ok() checks in the kernel are redundant or wrong, I think it makes a lot of sense to remove these. Arnd