On Mon, Mar 30, 2020 at 05:48:42AM -0700, Matthew Wilcox wrote: >On Mon, Mar 30, 2020 at 12:36:39PM +0000, Wei Yang wrote: >> If an entry is at the last level, whose parent's shift is 0, it is not >> expected to be a node. We can just leverage the xa_is_node() check to >> break the loop instead of check shift additionally. > >I know you didn't run the test suite after making this change. Hi, Matthew Would you mind picking up this thread again? Or what other concern you have? -- Wei Yang Help you, Help me