On Sun, 2008-08-10 at 05:39 +0900, OGAWA Hirofumi wrote: > Maybe, this is bio_discard(bio) != bio_discard(rq->bio)? Because it > seems to say bio_discard(bio) == blk_empty_barrier(rq) can merge, > rq_mergeable(rq) already checked barrier before this though... Yeah. It doesn't matter at the moment, as you say, but it's probably cleaner to make it bio_discard(). That's what I was thinking as I typed it anyway, I think. I've changed it in the git tree. -- David Woodhouse Open Source Technology Centre David.Woodhouse@xxxxxxxxx Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html