On Sat, Apr 25, 2020 at 10:32:44AM -0700, Andreas Dilger wrote: > On Apr 25, 2020, at 02:43, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > On Sat, Apr 25, 2020 at 12:11:59PM +0300, Amir Goldstein wrote: > >> FWIW, I agree with you. > >> And seems like Jan does as well, since he ACKed all your patches. > >> Current patches would be easier to backport to stable kernels. > > > > Honestly, the proper fix is pretty much trivial. I wrote it up this > > morning over coffee: > > > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/fiemap-fix > > > > Still needs more testing, though. > > The "maxbytes" value should be passed in from the caller, since this > may be different per inode (for ext4 at least). We should handle it, but not burden everyone else who has saner limits.
