On Mon, Apr 27, 2020 at 08:24:55AM +1000, Dave Chinner wrote: > > @@ -460,17 +456,13 @@ static void orangefs_invalidatepage(struct page *page, > > > > if (offset == 0 && length == PAGE_SIZE) { > > kfree((struct orangefs_write_range *)page_private(page)); > > - set_page_private(page, 0); > > - ClearPagePrivate(page); > > - put_page(page); > > + clear_fs_page_private(page); > > Ditto: > wr = clear_fs_page_private(page); > kfree(wr); You don't want to be as succinct as the btrfs change you suggested? kfree(clear_fs_page_private(page));